Repository navigation
Fixes #10684 - #10751
Merged
Merged
Fixes #10684#10751
Conversation
I kept the deprecated `pick` declarations, but added the proposed (JSDoc-influenced) [deprecation annotation](microsoft/TypeScript#390) to them. The added `pickone` and `pickset` declarations have identical types to their respective `pick` flavors.
Member
|
chance/chance.d.ts to author (@cbowdon). Could you review this PR? Checklist
|
3 of 4 tasks
Contributor
|
Thanks @LOZORD, I was just about to do the same fix :) |
Contributor
Author
|
@vvakame can this be merged yet? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
case 1. Add a new type definition.
--target es6and--noImplicitAnyoptions.-tests.tsor-tests.tsx.case 2. Improvement to existing type definition.
I kept the deprecated
pickdeclarations, but added the proposed (JSDoc-influenced) deprecation annotation to them. The addedpickoneandpicksetdeclarations have identical types to their respectivepickflavors.