Repository navigation
Backport: Remove unnecessary enrichment when querying for individual projects - #7258
Merged
Merged
Conversation
Removes metrics and versions enrichment from `ProjectQueryManager#getLatestProjectVersion(name)` and `#getProject(name, version)`. That data is only needed by the two `ProjectResource` endpoints that return the project to the client, but all other call sites paid the cost for it despite not needing it. In v4 those are the BOM and VEX upload endpoints, the badge endpoints, and the seven call sites that only resolve the previous latest version in order to unset its `isLatest` flag. Enrichment is now done directly at the call sites where it's needed. The badge endpoints already re-queried the metrics themselves, so they lose a redundant round trip as well. Both queries now also close their JDO `Query` via `executeAndCloseUnique`. (cherry picked from commit 980d239) Signed-off-by: nscuro <nscuro@protonmail.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes unnecessary enrichment when querying for individual projects.
Addressed Issue
Backports #6514
Additional Details
N/A
Checklist
This PR fixes a defect, and I have provided tests to verify that the fix is effectiveThis PR introduces changes to the database model, and I have updated the migration changelog accordinglyThis PR introduces new or alters existing behavior, and I have updated the documentation accordinglyThis PR is a substantial change (per the ADR criteria), and I have added an ADR underdocs/adr/