Repository navigation
update methods to estimate suppressed data - #360
Merged
Merged
Conversation
catherinebirney
commented
Aug 9, 2023
Contributor
- when estimating suppressed data, we now account for values of grandchildren
- new validation check to compare flow totals in a df before and after attribution
- updates to MLU functions to work for state methods
- update to substitute_nonexistent_values() to include all possible sectors at the state level
- drop 'AG LAND' mapping from USDA CoA Cropland Crosswalk because AG LAND (11) does not represent the summation of 111 and 112
- revisions to state water, state land, national land FBS yamls
…lished grandchildren values
…stureland. Add new pastureland for non-irrigated pastureland
…re/after attribution
… any grandchild sectors and to first check that any 1:1 parent:child relationships are captured in the df (these are excluded from usda_coa_cropland_naics)
…rce_sectors_to_more_aggregated_sectors() to more accurately capture fxn purpose
…nces that appear in state land FBS - does not impact other FBS methods
Contributor
|
I successfully tested GHG_national_2017 and TRI_DMR_state_2012. The former shows changes (expected due to use of employment FBS) while the latter does not. I did not review in depth your adjustments. |
bl-young
approved these changes
Aug 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.