Skip to content
This repository was archived by the owner on Sep 24, 2018. It is now read-only.
This repository was archived by the owner on Sep 24, 2018. It is now read-only.

Verify all model fields exposed in various contexts #605

Closed

Description

@danielbachhuber

We should produce a spreadsheet that identifies the fields associated with each model, and the view context required to expose them.

For instance, in #603, we're still not quite sure which user attributes should be exposed in which context. It would be best to have a master list to work from (with agreed-upon model attribute names).

Also, as a part of this issue, we should audit the query arguments for collections. As much as possible, they should be consistent.

Activity

  1. added this to the 2.0 milestone on Nov 12, 2014
  2. rmccue commented on Nov 21, 2014

    @rmccue
    Member

    IIRC, we have a list of these that we decided at the WCNYC discussion?

  3. danielbachhuber commented on Nov 21, 2014

    @danielbachhuber
    MemberAuthor

    Start of the list me thinks. I'll dig it up tomorrow.

  4. danielbachhuber commented on Nov 24, 2014

    @danielbachhuber
    MemberAuthor
  5. danielbachhuber commented on Nov 24, 2014

    @danielbachhuber
    MemberAuthor

    Few implementation questions I've run into:

    • Should you be able to get the field type from its name? (e.g. avatar => avatar_url, registered => registered_date, parent => parent_id)?
    • Should we make our returned resource models more precise (e.g. pages have menu_order, posts have sticky, attachments have mime type)?
    • If posts already have a type attribute, how are we supposed to include the label that's included in the index? Re Add object type-to-route mapping to index for discoverability #577
  6. danielbachhuber commented on Nov 27, 2014

    @danielbachhuber
    MemberAuthor

    From our conversation Monday:

    Should you be able to get the field type from its name? (e.g. avatar => avatar_url, registered => registered_date, parent => parent_id)?

    Yes, we should be more explicit across the board.

    Should we make our returned resource models more precise (e.g. pages have menu_order, posts have sticky, attachments have mime type)?

    Still TBD. I don't think we're at a conclusion.

  7. danielbachhuber commented on Nov 28, 2014

    @danielbachhuber
    MemberAuthor

    Kind of related, but more about routes, I think #655 is an argument for having each post type only accessible at a declared route (and dropping filter[type])

  8. danielbachhuber commented on Feb 10, 2015

    @danielbachhuber
    MemberAuthor

    @rachelbaker is documenting all of our responses here https://hackpad.com/ep/group/ngDYn5lciXQ

  9. danielbachhuber commented on Feb 19, 2015

    @danielbachhuber
    MemberAuthor

    @rachelbaker now that schemas have dropped and we have clear articulation of (most) of the existing resource attributes, how would you like to proceed?

  10. danielbachhuber commented on Feb 19, 2015

    @danielbachhuber
    MemberAuthor

    We could write the schema first for attachments, and build from there. Attachments is a tricky wicket because audio should have different attributes than video and file, etc.

  11. removed their assignment
    on Mar 31, 2015
  12. danielbachhuber commented on Mar 31, 2015

    @danielbachhuber
    MemberAuthor

    This is in pretty good shape now, but we should do a final pass as a part of b1

  13. danielbachhuber commented on Apr 27, 2015

    @danielbachhuber
    MemberAuthor

    These are pretty well documented in the schemas. We can open issues in the future as we have specific discussion points.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions