Repository navigation
Show the generate result on the button, with a details modal - #248
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a run, the React admin only showed "Successfully generated 9 items in 12.39s." in small green text below the button, plus a second notice at the top of the page. The 0.9.x screens linked every generated item. This brings that back, and adds more.
On the button
Details modal
REST
itemsandlist_url, from a newDescribes_Generated_Itemstrait. Documented in the OpenAPI schema.Fixes found along the way
{ code, message }) showed "An unknown error occurred.". They now show their message.wp_get_object_terms()call includedpost_format, a core quirk. They're now fetched one taxonomy at a time.Changelog lines included.
Checked: PHPCS, WPUnit (112 tests, 4 new in
GeneratedItemsTest), build, lint, typecheck and Jest (76 tests). On the demo site I clicked through Posts, Users, Terms, Comments and Attachments on desktop and mobile, plus a faked 403. Each click sends one generate request.