Repository navigation
Conflict with one setting in dFactory Repsonsive Lightbox plugin #33
Description
Expected Behavior
Custom classes can be added to widgets.
Actual Behavior
Custom classes (text or predefined) do not get written out to html, but are displayed in Widget UI. Even custom widget css classes built into theme no longer work. The standard ones do get written out to html successfully (widget-first, widget-last, etc)
Steps to Reproduce the Problem
- Install dFactory Responsive Lightbox plugin v 1.7.2 ( https://wordpress.org/plugins/responsive-lightbox/ )
- Goto Plugin Settings, and General Settings tab
- Select either "PrettyPhoto" or "Featherlight" as Default Lightbox (only tested with these two and the paid "Lightcase" that I purchased)
- Check the box (enable) for "Widgets : Enable lightbox for widgets content."
- Click Save at bottom.
- Clear browser cache, and reload site to see issue.
- Tried deactivating and deleting Widget CSS Classes and reinstalling, but issue persisted.
- Disabled Repsonsive Lightbox setting for widget contents to resolve.
Notes
- I use a page caching plugin, but cleared cache for all test steps.
Specifications
- Plugin Version: 1.5.2.1
- WordPress Version: 4.9.1
- Other plugins installed: many listed in attached image. Issue occurred on installing and configuring Responsive Lightbox
- Theme: Shaped Pixels v 1.1.2 ( http://shapedpixels.com )
- Browser: On Mac, tested with current versions of Firefox, Chrome and Safari
Activity
JoryHogeveen commentedon Jan 2, 2018
Hi @woolfa
Thank you for reporting!
I'm guessing that that plugin hooks into the same area as this one when enabled for widgets. I'll check the code asap to see if I can come up with a neat compatibility fix.
JoryHogeveen commentedon Jan 2, 2018
Error found and possibly fixed, but.. do you know the actual purpose of that setting? If I disable the widget setting the widget fancyboxes still work..
JoryHogeveen commentedon Jan 2, 2018
Got it, it's for the WYSIWYG widgets as far as I can see. Got a patch pushed to the
devbranch.If you would like to test it as well that would be great!
Please check the referenced pull request v1.5.3 (#34).
woolfa commentedon Jan 2, 2018
Tested v1.5.3 and that works perfectly now. Thank you for quick response!
woolfa commentedon Jan 2, 2018
...and, not sure what the setting exactly does in Responsive Lightbox plug-in. Not familiar enough with it yet.
JoryHogeveen commentedon Jan 2, 2018
@woolfa
Ok perfect, thanks!
I found that this impacts auto-lightbox handling for text/wysiwyg widgets. Maybe also other widgets, not sure.
I'll try to make an official update a.s.a.p.!