Repository navigation
Conversation
Co-authored-by: LuoRain <luotianyi@luotianyi.me>
There was a problem hiding this comment.
I reviewed this backport and didn't find any bugs. patches/ has code owners, though, so one of them should still take a look.
What was reviewed (from a standalone clone, so I couldn't open the Chromium sources):
.patchesgets one new entry at the end, and the patch's commit message explains the crash and links #55141. It also says the upstream unit tests were dropped.- The hunks match that description.
ExportSurfaceToForeignnow takes aWaylandToplevelWindow*and runs the callback with an empty string when the window isn't visible.OnHandleForwardpasses an empty handle through instead of returning just"wayland:". AsWaylandToplevelWindow()isn't null-checked, but the existingDCHECK_EQ(type, kWindow)sits just before that call, the same as upstream.- I couldn't check whether 45-x-y's Chromium has other callers of
ExportSurfaceToForeignthat still pass aWaylandWindow*. CI's build will catch that.
Extended reasoning...
This change adds one upstream Chromium cherry-pick and touches only ozone/wayland code (xdg_foreign_wrapper and linux_ui_delegate_wayland). It doesn't touch any security-sensitive surface such as auth, IPC or permissions. The patch matches the upstream CL apart from the documented removal of the unit tests. I deferred instead of approving because a CODEOWNERS group owns /patches/, and from a standalone clone I can't confirm that the changed signature compiles against the Chromium version pinned on 45-x-y.
|
Release Notes Persisted
|
Backport of #55568
See that PR for details.
Notes: Fixed a crash when using hidden window as the parent in Wayland.