Repository navigation
open source lwip2 - #3206
open source lwip2#3206d-a-v wants to merge 26 commits into
Conversation
* builder downloads original sources * precompiled version included * optionally selectable in arduino IDE menus * legacy lwip selected by default
|
Thanks for the PR! I haven't yet had time to review and test it, however I have one question: why do we want to keep old lwIP version around? I.e. why did you choose to add it side by side with the old one instead of replacing? |
Codecov Report
@@ Coverage Diff @@
## master #3206 +/- ##
=========================================
Coverage ? 27.57%
=========================================
Files ? 20
Lines ? 3655
Branches ? 678
=========================================
Hits ? 1008
Misses ? 2469
Partials ? 178Continue to review full report at Codecov.
|
|
My humble opinion states that it is early for total and definitive lwip replacement :) The current PR sets current-lwip-v1.4 as the default version. What could be done is to set v2 as the default version, leaving v1.4 still available just in case, at least for a little while. |
|
Also, for lwip-v2 to compile, a great deal of lwip-v1.4-include-files.h are needed (because of blobary-structures bindings). |
rename glue-lwip2/lwip/app to glue-lwip2/lwip/apps-esp for imported apps from lwip1.4(espressif)
(is needed for time.h)
|
now works with #3001 (sntp was missing) |
|
hi, what's the status of this? |
|
closing in favour of #3783 |
PLEASE check #3362 out instead