Repository navigation
chore(deps): Remove unused dependencies from workspace packages - #26230
Merged
Merged
Conversation
Co-Authored-By: Francesco Gringl-Novy <francesco.novy@sentry.io>
Contributor
size-limit report 📦Compared: b51ed21 (PR test merge using develop at 7bc0a5d) Against: 7bc0a5d (develop) · base run #65460 ✅ Baseline matches: this diff contains only this PR's changes.
|
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 8 not successful, 49 successful. See the run.
Successful checks
|
mydea
marked this pull request as ready for review
November 10, 2026 10:32
mydea
requested review from
Lms24,
andreiborza,
chargome,
msonnb and
nicohrubec
and removed request for
a team
November 10, 2026 10:32
chargome
approved these changes
Nov 10, 2026
51 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: Nothing imports or runs these dependencies, and no config or script names them. No other dependency needs them as a peer. Removing them only takes a package.json edit and a lockfile update. They were found with depcheck and a second check that also looked at CLI names in scripts, config and CSS files, and required peers up to two levels deep. Each remaining candidate was then checked by hand.
bundler-plugins:supports-colorandpremove.supports-coloris a runtime dependency. Nothing in the package uses it, and thesentryCLI only contains a copy bundled inside chalk.react:history-5and@types/history-5(the tests usehistory-4), and@types/node-fetch.gatsby:@testing-library/react.remix:@types/express.replay-internal:@babel/core.solidstart:node-mock-http.nitro:unstorage.hono:wrangler.ember:@embroider/compat.bun-integration-tests:@sentry-internal/test-utils.cloudflare-integration-tests:langchain. Only@langchain/typesafe/middlewareimports it, and the suite imports the package root.How to review: Most of the diff is the lockfile.
Unsure about: Whether
supports-colorin@sentry/bundler-pluginswas meant to do anything, such as enable colored output from a dependency. I couldn't find any code that uses it.Checks run: I built the affected packages with
build:dev:filter. These passed:testandlint:typesfor bundler-plugins, react, gatsby, remix, replay-internal, solidstart, nitro, hono and emberlint:typespnpm dedupe --checkI ran the bundler-plugins and nitro tests without the sandbox's
SENTRY_AUTH_TOKEN; with it set, a few auth-detection tests fail locally. The bun integration tests were not run because bun isn't installed.Related: the same cleanup for the E2E test apps is in its own PR.
via Francesco Gringl-Novy.
--
View Session [Sentry]