Skip to content

fix(fix): reject --apply-top=0 instead of applying all patches - #3252

Merged
G-Rath merged 1 commit into
google:mainfrom
ackama:cleanup/reject-0
Nov 9, 2026
Merged

G-Rath merged 1 commit into
google:mainfrom
ackama:cleanup/reject-0

Conversation

@G-Rath

@G-Rath G-Rath commented Nov 5, 2026

Copy link
Copy Markdown
Collaborator

Resolves #3234

@codecov-commenter

codecov-commenter commented Nov 5, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 82.48%. Comparing base (bfe2478) to head (7acaa1a).

Files with missing lines Patch % Lines
cmd/osv-scanner/fix/command.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3252      +/-   ##
==========================================
+ Coverage   82.46%   82.48%   +0.01%     
==========================================
  Files         120      120              
  Lines        7774     7777       +3     
==========================================
+ Hits         6411     6415       +4     
+ Misses       1363     1362       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@G-Rath
G-Rath enabled auto-merge (squash) November 5, 2026 21:26
@another-rex

another-rex commented Nov 5, 2026 •

Copy link
Copy Markdown
Collaborator

@michaelkedar I think this is fine to merge, but what are the scenarios where people want to pass 0 to this flag?

@G-Rath
G-Rath merged commit 0f45f6b into google:main Nov 9, 2026
25 checks passed
@G-Rath
G-Rath deleted the cleanup/reject-0 branch November 9, 2026 00:32
@michaelkedar

Copy link
Copy Markdown
Member

@michaelkedar I think this is fine to merge, but what are the scenarios where people want to pass 0 to this flag?

I guess if you wanted to temporarily disable the patching? It's not really something you'd want to have in general

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(fix): --apply-top=0 applies all available in-place patches

4 participants