Repository navigation
Remove event.which property fill #3235
Description
IE8 seems to be the last browser that didn't provide this natively. It's a bit tricky to test because it needs a real event and not a simulated one.
See also gh-2337, if we're not filling the property and just passing it on I don't know that we need to formally deprecate it in jQuery or generate a Migrate warning. If browsers ever tried to deprecate it via a console warning, the pass-through we do when copying the property would be the responsibility of the caller. If anything I'd say we add a note in our docs to use event.button or event.buttons where possible.
Activity
Event: Remove the event.which shim
mgol commentedon Jul 29, 2020
PR: #4765
mgol commentedon Jul 29, 2020
Why is this marked as a behavior change if all the browsers already support it?
mgol commentedon Jul 29, 2020
@dmethvin Sorry, I didn't notice this issue & your assignment before I made the PR. I reassigned the issue to myself.
dmethvin commentedon Jul 31, 2020
@mgol No problem, thanks for doing it! Should just be a case of deleting the
whichentry in event.js, I wouldn't think it changes any tests.Event: Remove the event.which shim
Event: Remove the event.which shim