Skip to content

Selector: Fix scoping logic of selector-native #5185

Closed

Description

@mgol

Description

As discussed in #5085 (comment), it would be worthwhile to try to fix the long-standing selector-native issue of not requiring all selector parts to match element under context, e.g. so that:

$div.find("div > *")

no longer matches children of $div.

My preliminary research indicates resolving this issue would cost about 1000 bytes minified gzipped; it'd still be 3300 bytes minified gzipped smaller than the full build compared to 4300 bytes minified gzipped without this change.

Link to test case

No test case since we don't upload selector-native versions anywhere. But the example from the description is pretty straightforward.

Activity

  1. added this to the 4.0.0 milestone on Dec 22, 2022
  2. self-assigned this
    on Dec 22, 2022
  3. added a commit that references this issue on Dec 22, 2022
    e480d28
  4. mgol commented on Dec 22, 2022

    @mgol
    MemberAuthor

    PR: #5186

  5. added a commit that references this issue on Feb 11, 2023
    d94e5e4
  6. added a commit that references this issue on Feb 13, 2023
    2e644e8
  7. locked as resolved and limited conversation to collaborators on Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions