Server#next reporter's cleanFromKeys implementation is not safe against cycles #89

Activity

1. ai commented on Apr 28, 2021

   

   ai

   on Apr 28, 2021

   Member

   More actions

   Am I right that you created this action on the server and not build it on the client?
2. ai

   transferred this issue fromlogux/serveron Apr 28, 2021
3. ai

   added

   part: node

   type: bug

   on Apr 28, 2021
4. erictheswift commented on Apr 28, 2021

   

   erictheswift

   on Apr 28, 2021 via email

   Author

   More actions

   Yep, that one was created in load channel callback Regards, Nikita

   …

   On 28 Apr 2021, at 14:16, Andrey Sitnik ***@***.***> wrote:  Am I right that you created this action on the server and not build it on the client? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.
5. ai commented on Apr 28, 2021

   

   ai

   on Apr 28, 2021

   Member

   More actions

   Since it is not security issue, I can accept PR, but do not want to fix it myself :)
6. erictheswift commented on Apr 28, 2021

   

   erictheswift

   on Apr 28, 2021 via email

   Author

   More actions

   I’d likely make a PR if you have a good idea how to improve it and not make it worse😅 Making this non-fatal? Leaving it fatal but with better error description?(via circuitbreaker) Regards, Nikita

   …

   On 29 Apr 2021, at 00:46, Andrey Sitnik ***@***.***> wrote:  Since it is not security issue, I can accept PR, but do not want to fix it myself :) — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.
7. ai commented on Apr 28, 2021

   

   ai

   on Apr 28, 2021

   Member

   More actions

   We can add circular dependencies check to server.log('preadd', (action, meta) => {}).

   Maybe it is better to do it only in server.options.env !== 'production'.