Skip to content

this.property completion does not include insertText if in parens #21320

Closed

Description

@mjbvz

TypeScript 2.7.0-2018-01-19

Code
For the js:

class Circle {
    constructor(radius) {
        this.radius = radius
    }

    foo() {
        return (rad)
    }
}

Trigger suggestions at the end of rad in return (rad)

Expected behavior:
Returned completion for radius includes insertText that turns the expression into (this.radius)

Actual behavior:
Returned completion does not include insertText:

 {
        "name": "radius",
        "kind": "property",
        "kindModifiers": "",
        "sortText": "0"
    },
    {
        "name": "radius",
        "kind": "warning",
        "kindModifiers": "",
        "sortText": "1"
    },

Activity

  1. changed the title [-]this.property completion not include insertText if in parens[/-] [+]this.property completion does not include insertText if in parens[/+] on Jan 23, 2018
  2. ghost closed this as completedin #21330on Jan 25, 2018
  3. locked and limited conversation to collaborators on Jul 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    BugA bug in TypeScriptFixedA PR has been merged for this issueVS Code TrackedThere is a VS Code equivalent to this issue

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions