Repository navigation
If call doesn’t resolve to an overload signature, issue a better error when the implementation would work #25488
Description
interface Foo { hello: string };
function bar1(...foos: Foo[]) {
bar2(...foos);
}
function bar2(foo1: Foo);
function bar2(foo1: Foo, foo2: Foo);
function bar2(...foos: Foo[]) {
return;
}Here we provide an error message like
Expected 1-2 arguments, but got 0 or more.
I just spoke to three engineers who had no indication of what was actually going wrong. We should
- Inform the user that implementation signatures aren't part of the overload set, and that they should consider making the overload an implementation signature
- Provide a quick fix to do so.
Reacted by Jason Gore
Activity
[-]Check if implementation signature is valid when overloads aren't[/-][+]If call doesn’t resolve to an overload signature, issue a better error when the implementation would resolve[/+][-]If call doesn’t resolve to an overload signature, issue a better error when the implementation would resolve[/-][+]If call doesn’t resolve to an overload signature, issue a better error when the implementation would work[/+]RyanCavanaugh commentedon Jul 9, 2018
I'm worried this will be misleading in a lot of cases
DanielRosenwasser commentedon Jul 13, 2018
I agree, but we should run it on user tests and the RWC and see what it looks like.
DanielRosenwasser commentedon Feb 21, 2019
Turns out this is a duplicate of #4797. Two Dans can't be wrong.
typescript-bot commentedon Feb 24, 2019
This issue has been marked as a 'Duplicate' and has seen no recent activity. It has been automatically closed for house-keeping purposes.