Repository navigation
Conversation
Author
|
@microsoft-github-policy-service agree |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the changes restoring reference code lenses for identifier-based export assignments.
No open issues 🎉
What changed in this PR
Restores reference code lenses for identifier-based export default and export = assignments in the native language server, addressing #65425 and matching TypeScript 6.0 behavior.
Changes:
- Recognizes export assignments as reference-lens nodes when their expression is an identifier.
- Anchors lenses to declaration names, including exported identifiers.
- Adds fourslash coverage and a baseline for default exports, export-equals assignments, and exclusion of literal expressions.
| File | Description |
|---|---|
tsc/testdata/baselines/reference/fourslash/codeLenses/codeLensExportAssignment01.baseline.jsonc |
Records expected lens positions and reference counts. |
tsc/internal/ls/codelens.go |
Enables identifier export-assignment lenses and updates range selection. |
tsc/internal/fourslash/tests/codeLensExportAssignment01_test.go |
Adds regression coverage for export-assignment code lenses. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #65425
Show the references code lens on
export default <expr>andexport =by treating export assignments as valid reference lens nodes in the native language server. This matches the 6.0 behavior.Added fourslash test
codeLensExportAssignment01with a baseline.AI disclosure: AI was used to help write the tests.