Repository navigation
test: skip the floating connected footer stroke test in WebKit - #347158
Merged
Bryan Chen (bryanchen-d) merged 1 commit intoNov 9, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the WebKit-specific test skip.
No open issues 🎉
What changed in this PR
Temporarily skips the floating connected-footer stroke test in WebKit to unblock macOS arm64 CI, while preserving Chromium coverage. Production rendering is unchanged.
Changes:
- Imports
isSafariand conditionally skips only the affected test. - Adds a TODO explaining WebKit’s missing
overflow-clip-marginsupport and suggesting a fallback before re-enabling coverage.
| File | Description |
|---|---|
src/vs/workbench/contrib/modernUI/test/browser/modernUI.contribution.test.ts |
Adds the WebKit-specific test skip and documents the rendering limitation. |
Review effort: Balanced
Collaborator
Author
|
Lee Murray (@mrleemurray) heads up that this is failing CI. |
It fails in WebKit since #347040, which blocks the macOS arm64 unit tests that gate the macOS arm64 and universal builds. WebKit doesn't support overflow-clip-margin, so overflow: clip hides the connected footer stroke in the card border. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Bryan Chen (bryanchen-d)
force-pushed
the
copilot/vscode/webkit-footer-stroke-skip
branch
from
November 9, 2026 21:49
8cdc0d2 to
896cf58
Compare
Bryan Chen (bryanchen-d)
marked this pull request as ready for review
November 9, 2026 22:26
Bryan Chen (bryanchen-d)
enabled auto-merge (squash)
November 9, 2026 22:26
Benjamin Christopher Simmonds (benibenj)
approved these changes
Nov 9, 2026
Bryan Chen (bryanchen-d)
deleted the
copilot/vscode/webkit-footer-stroke-skip
branch
November 9, 2026 22:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ModernUIContribution › floating connected footers paint through the strip to the rounded card perimeter, added in #347040, fails in WebKit on all 12 of its cases (strokeVisible: false,trueexpected). It failed deterministically in main CI 494297 and 494318. Only the macOS arm64Unit Tests (Node.js, Browser & Copilot)job runs WebKit, and that job gates the macOS arm64 and universal builds, so the 23:00 UTC insider would lose them.This skips only that test when
isSafari, with a TODO for the author. Chromium still runs it.Why WebKit differs
To let the connected footer's stroke paint in the floating card's 1 px border,
connectedPaneTabs.cssgives the cardoverflow: clip; overflow-clip-margin: border-box. WebKit doesn't supportoverflow-clip-margin(CSS.supports('overflow-clip-margin', 'border-box')isfalsethere), so it clips at the padding edge and hides the stroke in the border. This affects Safari on the web only. Desktop runs on Electron (Chromium).A
clip-path: inset(0 round <radius>)fallback paints the stroke in both engines, but the card's corner radii vary by layout, so that fix is left to the author. The TODO points at it.Validation