Repository navigation
docs: add QUERY to the documented retry default methods - #6062
Merged
Merged
Conversation
RetryHandler retries QUERY by default since QUERY support landed, but the RetryHandler and RetryAgent docs and the types still listed the old default. The errorCodes default in the types was also missing UND_ERR_SOCKET. Also add QUERY to Dispatcher.HttpMethod so it shows up in autocomplete.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6062 +/- ##
=======================================
Coverage 91.57% 91.57%
=======================================
Files 113 113
Lines 43938 43938
=======================================
+ Hits 40235 40237 +2
+ Misses 3703 3701 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
metcoder95
approved these changes
Oct 20, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
Follow up to the QUERY method support (#5459).
Rationale
RetryHandlerretriesQUERYrequests by default (lib/handler/retry-handler.js), but the docs forRetryHandlerandRetryAgentand the JSDoc intypes/retry-handler.d.tsstill list the old default without it. TheerrorCodesdefault in the types was also missingUND_ERR_SOCKET, which the code and the markdown docs already have.Changes
'QUERY'to themethodsdefault inRetryHandler.md,RetryAgent.mdandtypes/retry-handler.d.ts'UND_ERR_SOCKET'to theerrorCodesdefault intypes/retry-handler.d.ts'QUERY'toDispatcher.HttpMethodso it shows up in autocomplete like the other methodsFeatures
N/A
Bug Fixes
N/A (docs and types only)
Breaking Changes and Deprecations
N/A
Status