Repository navigation
[functools] Preserve return type in partialmethod (#16499) - #16736
Open
hrithiksaini99 wants to merge 2 commits into
Open
hrithiksaini99 wants to merge 2 commits into
hrithiksaini99 wants to merge 2 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16499.
Description
In #16499, wrapping a callable in
partialmethodresulted inpartialmethod[Any]in mypy (e.g.partialmethod(pprint, options={})wherepprint -> str).This was caused by the secondary
func: _Descriptoroverload where_Descriptor: TypeAlias = Any. Because_Descriptorhad no_Ttype parameter, mypy unified every callable argument against both overloads, joining_TwithAnyand losing return type information.Align
partialmethodwithpartial(which does not have an unconstrained descriptor overload):func: _Descriptoroverload on__init__/__new____new__fromselftoclsstdlib/@tests/test_cases/check_functools.pyassertingpartialmethodand instance calls preserve_T.