Repository navigation
Make modal backdrop visible - #735
Conversation
|
|
||
| /* Make the modal backdrop visible */ | ||
| body.menu-active .modal-backdrop, | ||
| :root .dropdown-details[open]>summary::before { |
There was a problem hiding this comment.
Some spacing would be nice: :root .dropdown-details[open] > summary::before {
|
I don't think the z-index you've set is good enough:
|
|
|
|
It looks like their modals are full of bugs that they can't see because the modals are invisible. In this case there are two backdrops being activated at once: one at document level and one inside the PR bar (which is needed because the whole bar is This last commit makes the bug less noticeable by making the PR-bar full-width:
|
|
In the first comment, I added a few more places where I tested this PR. |
But not fade out, that requires a bit more code
|
@bfred-it Do you think we could make the backdrop a bit less opaque? I'm asking specifically for the review dialogue which is visible in the screenshots above. I often would scroll and look at the code while I write my review comment. I'd like to be able to clearly see the code at that time. |
|
You know what, maybe I can. There are two overlapping layers there, that’s why it’s so dark, but I thought of something now. |
|
I fixed the issue! The second backdrop was only needed to darken the PR bar, so... I forced it to hide only the PR bar. So this now looks as expected. Before
After
|
hkdobrev
left a comment
There was a problem hiding this comment.
I've approved too soon!
With the latest changes I get this when I open Files changed:
After I scroll I get this:
| animation: fade-in 0.2s; | ||
| } | ||
| :root .pagehead ul.pagehead-actions { | ||
| position: static; /* Demote watch/start/fork */ |
|
You're right! I committed the wrong selector. Now it should work |
|
There's this weird darker area on the right here:
Could we get rid of it? 💭 |
How about closing the dropdown when the user scrolls it out of view? |
|
Can be done via IntersectionObserver. Can you open a new issue? |
|
Yes #778 |
GitHub's modals have an invisible layer which lets you click anywhere to close. This is invisible, which means that if you open a dropdown and then scroll it out of the view you will lose your first click and won't even know why.
Before
After
PR test areas