Skip to content
This repository was archived by the owner on Sep 10, 2026. It is now read-only.

fix: queryid not returning X-GraphQL-Keys headers - #294

Merged
jasonbahl merged 2 commits into
mainfrom
fix/queryid-not-outputting-keys
Sep 4, 2024
Merged

jasonbahl merged 2 commits into
mainfrom
fix/queryid-not-outputting-keys

Conversation

@jasonbahl

@jasonbahl jasonbahl commented Aug 29, 2024 •

Copy link
Copy Markdown
Collaborator

This fixes a bug where using all lowercase queryid as a GET param would execute the query but would not include the X-GraphQL-Keys in the response, preventing the documents from being properly tagged in the cache and thus not being invalidated from the cache properly.

Before

Executing a GET request with queryid as the query param leads to X-GraphQL-Keys being excluded from the response

CleanShot 2024-08-29 at 14 12 02

After

Now using lowercase queryid or camelcase queryId both work and return the X-GraphQL-Keys:

queryid:

CleanShot 2024-08-29 at 14 10 26

queryId:

CleanShot 2024-08-29 at 14 13 43


closes: #293

@jasonbahl
jasonbahl requested a review from josephfusco August 29, 2024 20:14
@jasonbahl jasonbahl self-assigned this Aug 29, 2024
@jasonbahl
jasonbahl merged commit b634d69 into main Sep 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

X-GraphQL-Keys not returned when using queryid instead of queryId

1 participant