Skip to content

Remove myself from contributors of react-bootstrap types - #45183

Merged
rbuckton merged 1 commit into
DefinitelyTyped:masterfrom
bes:remove-rb-name
Jun 4, 2020
Merged

Remove myself from contributors of react-bootstrap types#45183
rbuckton merged 1 commit into
DefinitelyTyped:masterfrom
bes:remove-rb-name

Conversation

@bes

@bes bes commented May 30, 2020

Copy link
Copy Markdown
Contributor

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If adding a new definition:

  • The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • Represents shape of module/library correctly
  • tslint.json should be present and it shouldn't have any additional or disabling of rules. Just content as { "extends": "dtslint/dt.json" }. If for reason the some rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.
  • tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <>
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
  • Include tests for your changes
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.

If removing a declaration:

  • If a package was never on Definitely Typed, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
  • Delete the package's directory.
  • Add it to notNeededPackages.json.

@typescript-bot typescript-bot added Where is GH Actions? GH Actions didn't give a response to this PR Popular package This PR affects a popular package (as counted by NPM download counts). Author is Owner The author of this PR is a listed owner of the package. labels May 30, 2020
@typescript-bot

typescript-bot commented May 30, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

@bes Thank you for submitting this PR!

This PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Have you considered adding tests to cover the change you're making? Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you.

Code Reviews

This PR can be merged once it's reviewed by a DT maintainer.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ❌ Only a DT maintainer can merge changes without tests

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Diagnostic Information: What the bot saw about this PR 
{
  "type": "info",
  "now": "-",
  "pr_number": 45183,
  "author": "bes",
  "owners": [
    "walkerburgin",
    "vsiao",
    "danilojrr",
    "Batbold-Gansukh",
    "octatone",
    "chengsieuly",
    "mretolaza",
    "katbusch",
    "vitosamson",
    "LKay",
    "aaronbeall",
    "jrakotoharisoa",
    "r3nya",
    "t49tran",
    "bes",
    "collingreen"
  ],
  "dangerLevel": "ScopedAndUntested",
  "headCommitAbbrOid": "544b6e7",
  "headCommitOid": "544b6e712f552b357745713f2a95382537e9f4be",
  "mergeIsRequested": false,
  "stalenessInDays": 3,
  "lastCommitDate": "2020-05-30T19:47:57.000Z",
  "lastCommentDate": "2020-05-30T19:52:53.000Z",
  "reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/45183/files",
  "hasMergeConflict": false,
  "authorIsOwner": true,
  "isFirstContribution": false,
  "popularityLevel": "Popular",
  "anyPackageIsNew": false,
  "packages": [
    "react-bootstrap"
  ],
  "files": [
    {
      "filePath": "types/react-bootstrap/index.d.ts",
      "kind": "definition",
      "package": "react-bootstrap"
    }
  ],
  "hasDismissedReview": false,
  "ciResult": "pass",
  "lastReviewDate": "2020-05-31T08:30:26.000Z",
  "reviewersWithStaleReviews": [],
  "approvalFlags": 2,
  "isChangesRequested": false
}

@typescript-bot

typescript-bot commented May 30, 2020

Copy link
Copy Markdown
Contributor

🔔 @walkerburgin @vsiao @DaniloJrr @Batbold-Gansukh @octatone @chengsieuly @mretolaza @katbusch @vitosamson @LKay @aaronbeall @jrakotoharisoa @r3nya @t49tran @collingreen - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot removed the Where is GH Actions? GH Actions didn't give a response to this PR label May 30, 2020
@danger-public

danger-public commented May 30, 2020

Copy link
Copy Markdown

Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files.
The check for missing properties isn't always right, so take this list as advice, not a requirement.

react-bootstrap (unpkg)

was missing the following properties:

  1. CloseButton

Generated by 🚫 dangerJS against 544b6e7

@typescript-bot

typescript-bot commented May 30, 2020

Copy link
Copy Markdown
Contributor

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊
master #45183 diff
Batch compilation
Memory usage (MiB) 162.3 165.8 +2.2%
Type count 41693 41693 0%
Assignability cache size 75898 75898 0%
Language service
Samples taken 2709 2709 0%
Identifiers in tests 3036 3036 0%
getCompletionsAtPosition
    Mean duration (ms) 703.9 698.5 -0.8%
    Mean CV 4.3% 4.3%
    Worst duration (ms) 1114.9 1071.0 -3.9%
    Worst identifier type strong
getQuickInfoAtPosition
    Mean duration (ms) 685.6 679.6 -0.9%
    Mean CV 4.1% 4.2% +3.7%
    Worst duration (ms) 1071.3 1036.3 -3.3%
    Worst identifier Body stacked

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

@typescript-bot typescript-bot added the Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. label May 30, 2020
r3nya
r3nya approved these changes May 31, 2020
View reviewed changes

@r3nya r3nya left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work!

@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label May 31, 2020
@rbuckton
rbuckton merged commit 6d0efb9 into DefinitelyTyped:master Jun 4, 2020
@sandersn sandersn mentioned this pull request Jun 4, 2020
Open
jjballano-qatium pushed a commit to jjballano-qatium/DefinitelyTyped that referenced this pull request Jun 16, 2020
@bes @jjballano-qatium
Remove myself from contributors of react-bootstrap types (DefinitelyT…
834d293 
…yped#45183)
ngbrown pushed a commit to ngbrown-forks/DefinitelyTyped that referenced this pull request Jul 11, 2020
@bes @ngbrown
Remove myself from contributors of react-bootstrap types (DefinitelyT…
67dbed9 
…yped#45183)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@r3nya r3nya r3nya approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Author is Owner The author of this PR is a listed owner of the package. Owner Approved A listed owner of this package signed off on the pull request. Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. Popular package This PR affects a popular package (as counted by NPM download counts).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bes @typescript-bot @danger-public @r3nya @rbuckton