Skip to content

Implemented Banner Backend. - #6440

Merged
nscuro merged 1 commit into
DependencyTrack:mainfrom
ElenaStroebele:banner-option
Jun 24, 2026
Merged

nscuro merged 1 commit into
DependencyTrack:mainfrom
ElenaStroebele:banner-option

Conversation

@ElenaStroebele

@ElenaStroebele ElenaStroebele commented Jun 17, 2026 •

Copy link
Copy Markdown
Contributor

Description

The backend implementation for the application banner is a public config property banner/config. The functionality is provided by the generic ConfigProperty endpoints. The JSON value is owned/sanitized by the frontend.

Addressed Issue

1418

Additional Details

Corresponding frontend PR: 1612

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have updated the migration changelog accordingly
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly
  • This PR is a substantial change (per the ADR criteria), and I have added an ADR under docs/adr/

@owasp-dt-bot

owasp-dt-bot commented Jun 17, 2026 •

Copy link
Copy Markdown

✅ Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@codacy-production

codacy-production Bot commented Jun 17, 2026 •

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 duplication

Metric Results
Duplication 0

View in Codacy

🟢 Coverage 100.00% diff coverage

Metric Results
Coverage variation Report missing for d8a8e521
Diff coverage ✅ 100.00% diff coverage (70.00%)

View coverage diff in Codacy

Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (d8a8e52) Report Missing Report Missing Report Missing
Head commit (52f92b6) 42289 36703 86.79%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#6440) 1 1 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

1 Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@ElenaStroebele
ElenaStroebele force-pushed the banner-option branch 3 times, most recently from 6ea87fa to cbf4437 Compare June 17, 2026 13:09
@ElenaStroebele
ElenaStroebele marked this pull request as ready for review June 17, 2026 13:26
@nscuro nscuro added this to the 5.1 milestone Jun 18, 2026
@nscuro nscuro added the enhancement New feature or request label Jun 18, 2026
@ElenaStroebele
ElenaStroebele force-pushed the banner-option branch 4 times, most recently from 8ed26c1 to 94a91c9 Compare June 24, 2026 11:22
@ElenaStroebele

Copy link
Copy Markdown
Contributor Author

@nscuro i think the failing test is unrelated to my changes ...

@nscuro

nscuro commented Jun 24, 2026

Copy link
Copy Markdown
Member

NVD is having availability issues. Please rebase with main, I merged a test refactor earlier that removes direct NVD calls from our test suite: #6505

Signed-off-by: ElenaStroebele <elena.stroebele@rohde-schwarz.com>
@nscuro
nscuro merged commit d1d4b40 into DependencyTrack:main Jun 24, 2026
17 checks passed
@ElenaStroebele
ElenaStroebele deleted the banner-option branch June 26, 2026 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants