Repository navigation
Stop bumping AffectedVersionAttribution.lastSeen - #6979
Merged
Merged
Conversation
The field / column was introduced at a time where vuln data source mirroring was NOT incremental. It doesn't provide any value outside of manual inspection, but leads to large amounts of `UPDATE` queries, which can slow down mirroring runs by means of network latency alone. This change merely deprecates the field and stops bumping it. `lastSeen` will always be equal to `firstSeen` until its removal. The corresponding DB column stays around to enable smooth rolling upgrades for users coming from 5.0.x. We'll drop the column in 5.2. Signed-off-by: nscuro <nscuro@protonmail.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Coverage variation | ✅ +0.00% coverage variation (-1.00%) |
| Diff coverage | ✅ 95.00% diff coverage (70.00%) |
Coverage variation details
Coverable lines Covered lines Coverage Common ancestor commit (7c3188e) 44003 38342 87.13% Head commit (4d71fd0) 43991 (-12) 38332 (-10) 87.14% (+0.00%) Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch:
<coverage of head commit> - <coverage of common ancestor commit>
Diff coverage details
Coverable lines Covered lines Diff coverage Pull request (#6979) 20 19 95.00% Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified:
<covered lines added or modified>/<coverable lines added or modified> * 100%
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
2 tasks done
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stops bumping
AffectedVersionAttribution.lastSeen.The field / column was introduced at a time where vuln data source mirroring was NOT incremental. It doesn't provide any value outside of manual inspection, but leads to large amounts of
UPDATEqueries, which can slow down mirroring runs by means of network latency alone.This change merely deprecates the field and stops bumping it.
lastSeenwill always be equal tofirstSeenuntil its removal. The corresponding DB column stays around to enable smooth rolling upgrades for users coming from 5.0.x. We'll drop the column in 5.2.Addressed Issue
Relates to #5934
Relates to #6971
Additional Details
N/A
Checklist
This PR fixes a defect, and I have provided tests to verify that the fix is effectiveThis PR introduces changes to the database model, and I have updated the migration changelog accordinglyThis PR introduces new or alters existing behavior, and I have updated the documentation accordinglyThis PR is a substantial change (per the ADR criteria), and I have added an ADR underdocs/adr/