Repository navigation
Treat >=0 ranges as wildcard during vers matching - #7329
Merged
Merged
Conversation
The semver4j library that NPM version comparisons are delegated to has a bug/quirk where comparisons of versions with suffixes are asymmetric. It only works as expected when major, minor, and patch are equal. It doesn't when one of the compared version omits any:
```
jshell> new Semver("0", Semver.SemverType.NPM).compareTo(new Semver("0.0.1-security", Semver.SemverType.NPM));
$3 ==> 1
jshell> new Semver("0.0.0", Semver.SemverType.NPM).compareTo(new Semver("0.0.1-security", Semver.SemverType.NPM));
$4 ==> -1
```
Assuming vers' wildcard comparator when `>=0` is detected sidesteps this issue because versatile can short-circuit that as "matches everything, always".
Signed-off-by: nscuro <nscuro@protonmail.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
🟢 Coverage 100.00% diff coverage · -0.01% coverage variation
Metric Results Coverage variation ✅ -0.01% coverage variation (-1.00%) Diff coverage ✅ 100.00% diff coverage (70.00%) Coverage variation details
Coverable lines Covered lines Coverage Common ancestor commit (86afed5) 44888 39259 87.46% Head commit (9115694) 44891 (+3) 39259 (+0) 87.45% (-0.01%) Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch:
<coverage of head commit> - <coverage of common ancestor commit>Diff coverage details
Coverable lines Covered lines Diff coverage Pull request (#7329) 4 4 100.00% Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified:
<covered lines added or modified>/<coverable lines added or modified> * 100%
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
2 tasks done
nscuro
added a commit
that referenced
this pull request
Sep 20, 2026
The semver4j library that NPM version comparisons are delegated to has a bug/quirk where comparisons of versions with suffixes are asymmetric. It only works as expected when major, minor, and patch are equal. It doesn't when one of the compared version omits any:
```
jshell> new Semver("0", Semver.SemverType.NPM).compareTo(new Semver("0.0.1-security", Semver.SemverType.NPM));
$3 ==> 1
jshell> new Semver("0.0.0", Semver.SemverType.NPM).compareTo(new Semver("0.0.1-security", Semver.SemverType.NPM));
$4 ==> -1
```
Assuming vers' wildcard comparator when `>=0` is detected sidesteps this issue because versatile can short-circuit that as "matches everything, always".
Signed-off-by: nscuro <nscuro@protonmail.com>
(cherry picked from commit 8e0f33f)
Signed-off-by: nscuro <nscuro@protonmail.com>
This was
linked to
issues
Oct 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Treats
>=0ranges as wildcard during vers matching.Addressed Issue
Fixes #7327
Additional Details
The semver4j library that NPM version comparisons are delegated to has a bug/quirk where comparisons of versions with suffixes are asymmetric. It only works as expected when major, minor, and patch are equal. It doesn't when one of the compared version omits any:
Assuming vers' wildcard comparator when
>=0is detected sidesteps this issue because versatile can short-circuit that as "matches everything, always".Checklist
This PR implements an enhancement, and I have provided tests to verify that it works as intendedThis PR introduces changes to the database model, and I have updated the migration changelog accordinglyThis PR introduces new or alters existing behavior, and I have updated the documentation accordinglyThis PR is a substantial change (per the ADR criteria), and I have added an ADR underdocs/adr/