Repository navigation
Fix lack of context in NVD & OSV unexpected status code exception messages - #7385
Conversation
…sages The previous "unexpected status code XXX" message was not helpful at all for users inspecting logs to figure out what's wrong. They now include what URL was requested and with what intent. Signed-off-by: nscuro <nscuro@protonmail.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
🟢 Coverage 100.00% diff coverage · +0.02% coverage variation
Metric Results Coverage variation ✅ +0.02% coverage variation (-1.00%) Diff coverage ✅ 100.00% diff coverage (70.00%) Coverage variation details
Coverable lines Covered lines Coverage Common ancestor commit (6d374e2) 45852 40185 87.64% Head commit (a4ae7fa) 45856 (+4) 40196 (+11) 87.66% (+0.02%) Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch:
<coverage of head commit> - <coverage of common ancestor commit>Diff coverage details
Coverable lines Covered lines Diff coverage Pull request (#7385) 9 9 100.00% Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified:
<covered lines added or modified>/<coverable lines added or modified> * 100%
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
utafrali
left a comment
There was a problem hiding this comment.
Clean, well-scoped fix that adds meaningful context (feed name, URL, status code) to previously opaque error messages in both NVD and OSV data sources. Test coverage is solid: NVD tests update their expected message strings and the two new OSV tests exercise both the full-archive and incremental-ID failure paths with distinct status codes. The incidental text block reformatting in OsvVulnDataSource produces an identical runtime string while reducing excessive line length.
Description
Fixes lack of context in NVD & OSV unexpected status code exception messages.
The previous "unexpected status code XXX" message was not helpful at all for users inspecting logs to figure out what's wrong. They now include what URL was requested and with what intent.
Addressed Issue
Relates to #7345 (comment)
Additional Details
N/A
Checklist
This PR implements an enhancement, and I have provided tests to verify that it works as intendedThis PR introduces changes to the database model, and I have updated the migration changelog accordinglyThis PR introduces new or alters existing behavior, and I have updated the documentation accordinglyThis PR is a substantial change (per the ADR criteria), and I have added an ADR underdocs/adr/