Repository navigation
PEP 503-normalize PyPI package names for vuln matching - #7546
Merged
Merged
Conversation
According to PEP 503: > The name should be lowercased with all runs of the characters > `.`, `-`, or `_` replaced with a single `-` character. Meaning `chartkit-core` and e.g. `chartkit._Core` should be treated equal. This requires normalization that Dependency-Track did not do, which led to false negatives when imported BOM data did not arrive already-normalized, since OSV *does* normalize package names. For example, https://osv.dev/vulnerability/MAL-2026-15932 is filed against `pkg:pypi/chartkit-core`, but a BOM could include `pkg:pypi/Chartkit.Core` and consequently wouldn't match. Thanks to Ilyas Makari of Aikido Security for reporting this issue. Signed-off-by: nscuro <nscuro@protonmail.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
🟢 Coverage 100.00% diff coverage · -0.02% coverage variation
Metric Results Coverage variation ✅ -0.02% coverage variation (-1.00%) Diff coverage ✅ 100.00% diff coverage (70.00%) Coverage variation details
Coverable lines Covered lines Coverage Common ancestor commit (fae4695) 45798 40205 87.79% Head commit (24036ba) 45807 (+9) 40204 (-1) 87.77% (-0.02%) Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch:
<coverage of head commit> - <coverage of common ancestor commit>Diff coverage details
Coverable lines Covered lines Diff coverage Pull request (#7546) 13 13 100.00% Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified:
<covered lines added or modified>/<coverable lines added or modified> * 100%
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This was referenced Oct 4, 2026
nscuro
added a commit
that referenced
this pull request
Oct 4, 2026
PyPI treats names that differ only in case or in runs of `.`, `-`, and `_` as the same package. Vulnerability sources such as OSV publish normalized names, so components whose PURLs used a different spelling, e.g. `pkg:pypi/Chartkit.Core`, were not matched. Normalize PyPI names when matching and when persisting vulnerable software, and normalize existing records during upgrade. Also bump the version to 4.14.5-SNAPSHOT for the next patch release. Backport of #7546 (a2f0b5e). Signed-off-by: nscuro <nscuro@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PEP 503-normalizes PyPI package names for vuln matching.
Addressed Issue
N/A
Additional Details
According to PEP 503:
Meaning
chartkit-coreand e.g.chartkit._Coreshould be treated equal. This requires normalization that Dependency-Track did not do, which led to false negatives when imported BOM data did not arrive already-normalized, since OSV does normalize package names.For example, https://osv.dev/vulnerability/MAL-2026-15932 is filed against
pkg:pypi/chartkit-core, but a BOM could includepkg:pypi/Chartkit.Coreand consequently wouldn't match.Thanks to Ilyas Makari of Aikido Security for reporting this issue.
Checklist
This PR implements an enhancement, and I have provided tests to verify that it works as intendedThis PR introduces changes to the database model, and I have updated the migration changelog accordinglyThis PR introduces new or alters existing behavior, and I have updated the documentation accordinglyThis PR is a substantial change (per the ADR criteria), and I have added an ADR underdocs/adr/