Description

Tokenizing a file where the name of a const declaration is the last non-empty token, such as const A with nothing after it, aborts with An error occurred during processing; checking has been aborted. The error message was: Undefined array key ... in src/Tokenizers/PHP.php.

The loop that walks forward from the constant name to the next non-empty token ends with $i equal to $numTokens when there is no such token, and the $tokens[$i] === '=' check that follows then reads an index that does not exist. This adds an isset() guard so the check only runs when that token is present.

Suggested changelog entry

Fixed a tokenizer error ("Undefined array key") which could occur when the name of a const declaration was the last non-empty token in a file.

Related issues/external references

Fixes #1451

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
  • This change is only breaking for integrators, not for external standards or end-users.
• Documentation improvement

PR checklist

• I have checked there is no other PR open for the same change.
• I have read the Contribution Guidelines.
• I grant the project the right to include and distribute the code under the BSD-3-Clause license (and I have the right to grant these rights).
• I have added tests to cover my changes.
• I have verified that the code complies with the projects coding standards.
• [Required for new sniffs] I have added XML documentation for the sniff.
• I have opened a sister-PR in the documentation repository to update the Wiki.