Description

When the name of a const declaration is the last non-empty token in a file (for example const A with nothing following it during live coding), PHPCS aborts tokenizing with a fatal Undefined array key error.

Inside the const-declaration handling in PHP::tokenize(), a loop walks forward from the constant name looking for the next non-empty token to check whether it is an =. When the constant name is the last non-empty token, the loop ends with $i === $numTokens, so the following $tokens[$i] === '=' check reads an index that does not exist. This adds an $i < $numTokens guard before that access, so the file tokenizes without a fatal error.

Suggested changelog entry

Fixed a fatal "Undefined array key" error when tokenizing a file where a const name is the last non-empty token.

Related issues/external references

Fixes #1451

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
  • This change is only breaking for integrators, not for external standards or end-users.
• Documentation improvement

PR checklist

• I have checked there is no other PR open for the same change.
• I have read the Contribution Guidelines.
• I grant the project the right to include and distribute the code under the BSD-3-Clause license (and I have the right to grant these rights).
• I have added tests to cover my changes.
• I have verified that the code complies with the projects coding standards.
• [Required for new sniffs] I have added XML documentation for the sniff.
• I have opened a sister-PR in the documentation repository to update the Wiki.