Skip to content

Option Page now completely broke without remote access #1473

Closed

Description

@chimok

Bug Description

Steps to reproduce

  1. Upgrade plugin to 3.3.1
  2. Visit Plugin option page

Screenshots

image

Additional Context

Due to your site's configuration, you may not be able to activate the performance features, unless the underlying plugin is already installed. Please install the relevant plugins manually.

There is nothing wrong with our server configuration. There is something wrong with your plugin.
We don't want the website is calling home, that's why we disable any remote request. And we don't need then, because we're using a composer based setup and update/install everything in our local DEV system.

It should be still possible to change plugin options, but now i can't do anything.

  • PHP Version: 8.2
  • Plugin Version: 3.3.1

Activity

  1. moved this to Not Started/Backlog 📆 in WP Performance Ongoingon Aug 15, 2024
  2. swissspidy commented on Aug 15, 2024

    @swissspidy
    Member

    Thanks for your report, that's certainly not a great experience. We shouldn't be cluttering the admin page if we can't fetch information about the plugins recommended/used by Performance Lab.

    Which of the few Performance Lab plugins do you have installed?

    How are you disabling remote requests?

  3. chimok commented on Aug 15, 2024

    @chimok
    Author

    @swissspidy I use pre_http_request, it worked well with the previous version. I use only modern images (former webp uploads)

    /**
     * Block external WordPress API request
     */
    function vdplug_api_block_request($pre, $args, $url)
    {
        if (strpos($url, 'wordpress.org')) {
            return true;
        } else {
            return $pre;
        }
    }
    add_filter('pre_http_request', 'vdplug_api_block_request', 10, 3);
  4. moved this from Not Started/Backlog 📆 to To Do 🔧 in WP Performance Ongoingon Aug 15, 2024
  5. self-assigned this
    on Aug 15, 2024
  6. moved this from To Do 🔧 to In Progress 🚧 in WP Performance Ongoingon Aug 15, 2024
  7. westonruter commented on Aug 15, 2024

    @westonruter
    Member

    @chimok Note that this screen includes no plugin options, other than to facilitate installation and activation of the standalone plugins:

    image

    All of the Settings links simply point to the plugins' respective settings screens in the admin. They are also accessible via Settings links in the plugin list table, for example:

    image

    I've opened #1474 to improve the error message on the Performance screen.

  8. moved this from In Progress 🚧 to Code Review 👀 in WP Performance Ongoingon Aug 15, 2024
  9. moved this from Code Review 👀 to Done 😃 in WP Performance Ongoingon Aug 16, 2024
  10. vegetable-bits commented on Sep 23, 2025

    @vegetable-bits

    @westonruter @mukeshpanchal27 The problem is back with 4.0.0.

    Image
  11. westonruter commented on Sep 23, 2025

    @westonruter
    Member

    @vegetable-bits Where is your site hosted where you're experiencing this issue?

    The issue could also be a temporary network issue.

  12. vegetable-bits commented on Sep 24, 2025

    @vegetable-bits

    @westonruter It's a private company server, I do simply not allow external connections.

    You see I have 4 plugins (active), I can configure the plugins like webp-uploads in their plugin settings. But if you could show the settings in performance plugin if a plugin is already active, that would be so much more convenient. There's no reason for remote connection if the plugin is install and active.

  13. westonruter commented on Sep 24, 2025

    @westonruter
    Member

    @vegetable-bits Thanks, I've opened #2189 to track this.

    In any case, the problem is not back as was originally reported for this issue. It's a different issue, because you are blocking external requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

Relationships

None yet

Development

No branches or pull requests

Issue actions