Repository navigation
Fix CSS lint with a Tailwind v4 aware stylelint config - #237
Merged
Merged
Conversation
bordoni
force-pushed
the
style/css-lint
branch
from
October 17, 2026 17:58
e728e36 to
4483225
Compare
Tabs, blank lines, leading zeros, lowercase hex and keywords, double quotes, ::before/::after, font-weight 400/700. Keeps .select2-container's display: inline-block, which the declaration-block-no-duplicate-properties fixer removed as a duplicate of the IE7 *display hack.
- Legacy -webkit-/-moz-linear-gradient(center bottom|top) -> (bottom|top): same direction, standard legacy keyword. - Move the IE filter above the prefixed background-image fallbacks so the fallbacks are consecutive. - Put display: inline-block right before the IE7 *display hack (after zoom) for the same reason. - Drop background-clip: padding-box on .select2-arrow: the background shorthand right after it always reset it. - Fold the second .select2-container-multi .select2-choices block (min-height) into the first. - Fix a stray space before a selector.
- Remove the seven empty .ui-icon state rules (their theme images were stripped long ago). - black -> #000. - Keep the theme section's repeated .ui-icon and .ui-widget-overlay blocks and line-height: 1.8em (em inherits differently from unitless) with commented stylelint-disable-next-line. - Wrap the long license header line.
…egacy pcss - font-family-no-missing-generic-family-keyword ignores dashicons (icon font). - no-descending-specificity is off for src/resources/pcss: the legacy jQuery UI / Select2 / datepicker styles depend on source order. - select2-wordpress.pcss gets a comment explaining why the empty file stays (no-empty-source).
…oups Comments above the @import and @custom-variant groups keep them visually separate now that stylelint disallows blank lines between blockless at-rules. The Tailwind import lines themselves are unchanged.
bordoni
force-pushed
the
style/css-lint
branch
from
October 17, 2026 18:53
4483225 to
40eeaa7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Takes
bun run lint:cssfrom 1520 problems to 0. CSS lint never ran in CI before (it gets a step in #241)..stylelintrc.jsallows the Tailwind v4 at-rules (@theme,@custom-variant,@utility,@source…).stylelint --fixover the admin styles, then the leftovers inselect2.pcssandjquery-ui.pcssby hand..pcss.Stacked on #236.
Checked: the compiled CSS is equivalent (only obsolete
-moz-gradients and empty rules dropped), and screenshots of all 5 pages match the pre-cleanup ones.