Skip to content

feat: deprecate --experimental- flags in favor of shorter --x- versions - #2589

Merged
another-rex merged 2 commits into
google:mainfrom
ackama:feat/rename-exp-flags
Oct 2, 2026
Merged

another-rex merged 2 commits into
google:mainfrom
ackama:feat/rename-exp-flags

Conversation

@G-Rath

@G-Rath G-Rath commented Mar 4, 2026

Copy link
Copy Markdown
Collaborator

"experimental" is a tedious word to type, so this switches to the much shorter "x" similar to the convention used by the Go stdlib

@codecov-commenter

codecov-commenter commented Mar 5, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.15%. Comparing base (2e25915) to head (64577e2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2589      +/-   ##
==========================================
+ Coverage   82.13%   82.15%   +0.02%     
==========================================
  Files         118      118              
  Lines        7681     7690       +9     
==========================================
+ Hits         6309     6318       +9     
  Misses       1372     1372              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@G-Rath

G-Rath commented Mar 5, 2026

Copy link
Copy Markdown
Collaborator Author

ugh the "flags action" order thing is an issue here too 🤦

@G-Rath
G-Rath force-pushed the feat/rename-exp-flags branch from 28eced9 to 54920ab Compare March 5, 2026 00:39
@G-Rath
G-Rath force-pushed the feat/rename-exp-flags branch 4 times, most recently from d5d8643 to 400a3f6 Compare March 10, 2026 00:19

@another-rex another-rex left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

},
&cli.BoolFlag{
Name: "x-no-default-plugins",
Usage: "disable default plugins, instead using only those enabled by --experimental-plugins",

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should mention --x-plugins right?

@github-actions

Copy link
Copy Markdown

This pull request has not had any activity for 60 days and will be automatically closed in two weeks

@github-actions github-actions Bot added the stale The issue or PR is stale and pending automated closure label May 16, 2026
@G-Rath G-Rath added backlog Important but currently unprioritized and removed stale The issue or PR is stale and pending automated closure labels May 16, 2026
@G-Rath
G-Rath force-pushed the feat/rename-exp-flags branch from 400a3f6 to 51cd9f7 Compare June 17, 2026 19:13
@github-actions

Copy link
Copy Markdown

This pull request has not had any activity for 60 days and will be automatically closed in two weeks

@github-actions github-actions Bot added the stale The issue or PR is stale and pending automated closure label Aug 16, 2026
@G-Rath G-Rath removed the stale The issue or PR is stale and pending automated closure label Aug 16, 2026
@G-Rath
G-Rath force-pushed the feat/rename-exp-flags branch 4 times, most recently from 4beac27 to 6dede2b Compare October 1, 2026 04:08
@G-Rath
G-Rath marked this pull request as ready for review October 1, 2026 04:13
@G-Rath
G-Rath force-pushed the feat/rename-exp-flags branch 2 times, most recently from 1ac4f6d to d91a64e Compare October 1, 2026 04:23
@G-Rath
G-Rath force-pushed the feat/rename-exp-flags branch from d91a64e to 2697f7b Compare October 1, 2026 18:03

@another-rex another-rex left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Exit: 128,
},
{
Name: "deprecated_extractors_cancelled_out_specified_individually",

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm it's not clear what this is trying to test?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a copy of extractors_cancelled_out_specified_together just using a deprecated flag mixed in, which itself is a general test showing that it's not an error to have "enable" and "disable" plugins overlap

@G-Rath
G-Rath force-pushed the feat/rename-exp-flags branch from 2697f7b to 64577e2 Compare October 2, 2026 01:09
@G-Rath
G-Rath requested a review from another-rex October 2, 2026 01:17
@another-rex
another-rex merged commit 2ec4d7b into google:main Oct 2, 2026
25 checks passed
@another-rex
another-rex deleted the feat/rename-exp-flags branch October 2, 2026 03:10
nikumar1206 added a commit to team-loco/loco that referenced this pull request Nov 3, 2026
osv-scanner 2.7.0 adds --x- aliases for the experimental flags and
deprecates the --experimental- spellings (google/osv-scanner#2589). The
source scans run osv-scanner-action v2.7.0, whose image ships 2.7.0, so
the alias is available to both jobs.
nikumar1206 added a commit to team-loco/loco that referenced this pull request Nov 3, 2026
osv-scanner 2.7.0 adds --x- aliases for the experimental flags and
deprecates the --experimental- spellings (google/osv-scanner#2589). The
source scans run osv-scanner-action v2.7.0, whose image ships 2.7.0, so
the alias is available to both jobs.
nikumar1206 added a commit to team-loco/loco that referenced this pull request Nov 3, 2026
osv-scanner 2.7.0 adds --x- aliases for the experimental flags and
deprecates the --experimental- spellings (google/osv-scanner#2589). The
source scans run osv-scanner-action v2.7.0, whose image ships 2.7.0, so
the alias is available to both jobs.
nikumar1206 added a commit to team-loco/loco that referenced this pull request Nov 3, 2026
* chore(deps): update dependency pinact to v5.0.2

* chore(deps): update dependency buf to v1.75.0

* chore(deps): update dependency gh to v2.103.3

* chore(deps): update dependency golangci-lint to v2.15.0

* chore(deps): update uv to v0.13.6

* chore(deps): update dependency github:pressly/goose to v3.29.0

* chore(deps): update dependency osv-scanner to v2.7.0

* chore(deps): update github actions

* fix(deps): update dependency zensical to v0.0.74

* chore(deps): update dependency playwright to v1.64.1

* fix(deps): update dependency pytest to v9.2.0

* fix(deps): update module github.com/pressly/goose/v3 to v3.29.0

api and observability-proxy run their migrations through the goose
library, and mise pins the goose CLI that db:migrate and the e2e runner
use against the same api/migrations. Move the library to the version
the CLI moved to so both apply migrations with the same release.

v3.29.0 adds YDB environment credentials and upgrades dependencies;
nothing in it changes the Postgres or ClickHouse providers. The go get
raises the indirect requirements goose needs, among them grpc 1.84.0 and
golang.org/x/mod 0.42.0 in api.

* ci(osv): pass --x-exclude instead of the deprecated flag

osv-scanner 2.7.0 adds --x- aliases for the experimental flags and
deprecates the --experimental- spellings (google/osv-scanner#2589). The
source scans run osv-scanner-action v2.7.0, whose image ships 2.7.0, so
the alias is available to both jobs.

* chore(renovate): strip the v prefix from github: backend tool tags

The goose update (#1128) wrote "github:pressly/goose" = "v3.29.0" into
mise.toml and specifiers = ["v3.29.0"] into mise.lock, where every other
pin is a bare version; the controller-tools update (#1127) does the same.
Renovate's lookup gives newValue 3.29.0 but newVersion v3.29.0, the raw
release tag, and the mise lock it runs for the lockfile rewrites the
request in mise.toml to that tag.

extractVersion already handled this for infisical. Apply it to every
github: backend tool too; a renovate --platform=local --dry-run=lookup
now reports newVersion 3.29.0 for goose and 0.23.0 for controller-tools.
matchDepNames takes a regex here because a "github:**" glob does not
cross the slash in owner/repo. The optional v keeps a tool whose tags
have no prefix from losing every release.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backlog Important but currently unprioritized

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants