Missing API master issue #262

Activity

1. cartazio commented on Dec 15, 2019

   

   cartazio

   on Dec 15, 2019 via email

   Contributor

   More actions

   yay, thx! this sort of concrete actionable feedback is really helpful! theres some tools somewhere for doing haddock or .hi file based api diffs, something like that would be super helpful to sanity check cleanup vector with

   …

   On Sun, Dec 15, 2019 at 6:16 PM Merijn Verstraaten ***@***.***> wrote: This issue is to document functions that are in *some* of the vector modules, but not others. I will update and add missing functions as I find them: Data.Vector.Storable: - imapM - imapM_ — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#262?email_source=notifications&email_token=AAABBQWKCH4U3WMBDWCQGTTQY23EJA5CNFSM4J3CRNE2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IATCTVQ>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAABBQRR3T74LS6YFDU7NULQY23EJANCNFSM4J3CRNEQ> .
2. merijn commented on Dec 15, 2019

   

   merijn

   on Dec 15, 2019

   Author

   More actions

   Right now I'm just writing down everything I'm having to reimplement to get my stuff working >.>
   A substantial number are already in Data.Vector.Generic, so I'm unsure why they aren't exported already.
3. Shimuuar

   added a commit that references this issue on Feb 2, 2020

   Export imap{,_} from Primitive/Storable for consistency

   ...

   This issue will close once commit dc5f339 is merged into the 'master' branch.

   dc5f339
4. merijn commented on May 28, 2020

   

   merijn

   on May 28, 2020

   Last edited by merijn

   Author

   More actions

   Edit: actually, they're just under a different heading, nevermind!
5. cartazio commented on May 28, 2020

   

   cartazio

   on May 28, 2020 via email

   Contributor

   More actions

   Not necessarily. In terms of stream fusion yes, but for materialized vectors both are valid.

   …

   On Thu, May 28, 2020 at 9:59 AM Merijn Verstraaten ***@***.***> wrote: Various monadic folds: - foldM - ifoldM I suppose only strict left folds are sensible here? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#262 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAABBQTGMMI526CKPKUINKLRTZU4BANCNFSM4J3CRNEQ> .
6. fumieval

   added 3 commits that reference this issue on Jun 6, 2020

   Implement iforM and iforM_ (haskell#262)

   359bc9f

   Implement iforM and iforM_ (haskell#262)

   1bfe812

   Implement iforM and iforM_ (haskell#262)

   0793491
7. lehins

   added a commit that references this issue on Jun 8, 2020

   Merge pull request #311 from fumieval/master

   ...

   4e20ae0
8. Shimuuar commented on Jun 8, 2020

   

   Shimuuar

   on Jun 8, 2020

   Contributor

   More actions

   This leaves only

   Mutable modules should probably re-export PrimState and PrimMonad so it's easier to write PrimMonad generic code without adding the additional primitive dependency and an extra import.

   I think it's fair request and won't cause name clashes since module is expected to imported qualified
9. Shimuuar

   added this to the 0.13 milestone on Jun 11, 2020
10. Shimuuar

    added a commit that references this issue on Jun 20, 2020

    Reexport PrimMonad from mutable vectors

    ...

    This issue will close once commit bcf528e is merged into the 'master' branch.

    bcf528e
11. Shimuuar

    closed this as completedin #320on Jun 23, 2020
12. Shimuuar

    added a commit that references this issue on Jun 23, 2020

    Reexport PrimMonad from mutable vectors (#320)

    ...

    This issue will close once commit c7858a7 is merged into the 'master' branch.

    c7858a7
13. lehins

    added a commit that references this issue on Jan 16, 2021

    Implement iforM and iforM_ (#262)

    b3f822a