0.12.1.1 breaking change w.r.t. 0.12.0.3 #287

Activity

1. jkachmar

   added a commit that references this issue on Feb 1, 2020

   Restricts vector < 0.12.1.0 (haskell/vector#287)

   ...

   fca52e5
2. lehins commented on Feb 1, 2020

   

   lehins

   on Feb 1, 2020

   Last edited by lehins

   Contributor

   More actions

   Not sure what was the motivation behind this change, but the proper way to fix this issue I see is bring back mkType as deprecated:

   mkType :: String -> DataType
   {-# INLINE mkType #-}
   {-# DEPRECATED mkType "In favor of mkVectType" #-}
   mkType = mkNoRepType

   and make new release vector-0.12.1.2, while deprecating vector-0.12.1.0 and vector-0.12.1.1

   @cartazio Would you be keen to making such release if I fix it in proposed way?
3. cartazio commented on Feb 1, 2020

   

   cartazio

   on Feb 1, 2020 via email

   Contributor

   More actions

   Absolutely I did have an “oh no moment” late last night when I remembered that the data instance had existed but was so useless that I was used to treating it as not existing. So indeed I can do that post haste. Email / msg me or holler on a ticket when you think it’s in a good shape. Or I can do a thing. Was pointed out to me that currently we don’t have terribly good test coverage atm wrt hpc coverage metrics (granted we couldn’t even run the optimized test suite till last week :) @hvr @davean is https://hackage.haskell.org/package/hackage-diff The tool you two have used for doing api diffs? Or was it a different one? Probably would be good to add to release engineering workflow / checklist (which we don’t have quite yet ;))

   …

   On Sat, Feb 1, 2020 at 1:03 PM Alexey Kuleshevich ***@***.***> wrote: Not sure what was the motivation behind this change, but the proper way to fix this issue I see is bring back mkType as deprecated: mkType :: String -> DataType {-# INLINE mkType #-} {-# DEPRECATED mkType "In favor of mkVectType" #-} mkType = mkNoRepType and make new release vector-0.12.1.3, while deprecating vector-0.12.1.1 and vector-0.12.1.2 @cartazio <https://github.com/cartazio> Would you be keen to making such release if I fix it in proposed way? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#287?email_source=notifications&email_token=AAABBQQZABUCLHPHFQZBBFTRAW2QZA5CNFSM4KOUPBK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKRC6RA#issuecomment-581054276>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAABBQSRXFPNDHGMQHTBP4LRAW2QZANCNFSM4KOUPBKQ> .
4. lehins

   added a commit that references this issue on Feb 1, 2020

   Bring back `mkType` function and deprecate it. Fix haskell#287 Also:

   ...

   This issue will close once commit 9c1ae17 is merged into the 'master' branch.

   9c1ae17
5. lehins commented on Feb 1, 2020

   

   lehins

   on Feb 1, 2020

   Last edited by lehins

   Contributor

   More actions

   The fix is ready: #288

   The tool you two have used for doing api diffs?

   There was recently an announcement of policemen that could potentially help with that. Have not used it though, so can't vouch for it.
   https://www.reddit.com/r/haskell/comments/ew1vd5/blog_post_policeman_new_way_to_assign_pvp/
6. chessai commented on Feb 1, 2020

   

   chessai

   on Feb 1, 2020

   Member

   More actions

   @lehins unfortunately per PVP depreciation entails a majour version bump. So maybe that isn't the right choice? Unsure.
7. lehins commented on Feb 1, 2020

   

   lehins

   on Feb 1, 2020

   Contributor

   More actions

   PVP should have been fixed long time ago: haskell/pvp/issues/12

   But thats fine, I'll make a fix without DEPRECATE pragma.
8. lehins

   added a commit that references this issue on Feb 1, 2020

   Bring back `mkType` function and deprecate it. Fix haskell#287 Also:

   ...

   This issue will close once commit 716074a is merged into the 'master' branch.

   716074a
9. chessai commented on Feb 1, 2020

   

   chessai

   on Feb 1, 2020

   Member

   More actions

   @lehins i personally agree. Hopefully it will be updated soon. Unfortunately for now, we must adhere
10. lehins commented on Feb 1, 2020

    

    lehins

    on Feb 1, 2020

    Contributor

    More actions

    @chessai I would not have my hopes up, it's been 3 years since that linked issue on pvp
11. cartazio

    added 2 commits that reference this issue on Feb 1, 2020

    Bring back `mkType` function and deprecate it. Fix #287 Also:

    ...

    This issue will close once commit 6e41782 is merged into the 'master' branch.

    6e41782

    Bring back `mkType` function. Fix #287 Also:

    ...

    This issue will close once commit 8eb550c is merged into the 'master' branch.

    8eb550c
12. jkachmar commented on Feb 1, 2020

    

    jkachmar

    on Feb 1, 2020

    Last edited by jkachmar

    Author

    More actions

    Unfortunately for now, we must adhere

    Must we?

    😄React with 😄1Reacted by Alexey Kuleshevich
13. cartazio commented on Feb 1, 2020

    

    cartazio

    on Feb 1, 2020

    Contributor

    More actions

    FIXED
14. cartazio

    closed this as completedon Feb 1, 2020
15. Shimuuar

    added a commit that references this issue on Apr 11, 2020

    Bring back `mkType` function. Fix #287 Also:

    ...

    This issue will close once commit f3f127d is merged into the 'master' branch.

    f3f127d
16. lehins

    added a commit that references this issue on Jun 5, 2020

    Bring back `mkType` function. Fix haskell#287 Also:

    ...

    This issue will close once commit 249a2e7 is merged into the 'master' branch.

    249a2e7