saved.shift is not a function

My app auto-upgraded to 3.4.0 from 3.3.1 and broke with this error:

I'll append the browser version in a comment shortly.

user_agent: "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/73.0.3683.86 Safari/537.36"

trace: "TypeError: saved.shift is not a function
at HTMLDivElement.handler (...)
at HTMLDivElement.dispatch (...)
at HTMLDivElement.elemData.handle (...)

Sorry, there is not enough information to go on here. You can find help on https://stackoverflow.com. If after sorting out the issue you find there is a change needed in jQuery core, please open a new issue and follow the instructions in the issue template, including providing a test case from https://jsbin.com.

Sorry, because it wasn't triggered directly by my code, and because it doesn't seem to happen consistently, I don't know how to create a test case.

Fair enough, but the issue needs to be fleshed out more regardless.

Luckily "saved.shift" only occurs once in the source-code. Strange that the comment says IE <= 9 - 11+ but that it is being run on Chrome.

dataPriv.set( this, type, jQuery.event.trigger(
  // Support: IE <=9 - 11+
  // Extend with the prototype to reset the above stopImmediatePropagation()
  jQuery.extend( saved.shift(), jQuery.Event.prototype ),
  saved,
  this
) );

Seems to happen because saved is not an array, example:

> let saved = ''
> saved.shift()
VM116:1 Uncaught TypeError: saved.shift is not a function

@dsandber

@dsandber Unfortunately, we cannot do much without a test case we can run, the error itself doesn't say much. We usually require a small test case without external dependencies as most errors user have is actually a bug on their app part but since this code is new in 3.4.0 & it's one of the most trickiest new part, it's possible we broke something so I'd be open to looking at a slightly bigger test case. But I still need at least a website with this bug, with an easy way to reproduce it myself. Ideally I'd have both one with jQuery 3.3.1 & 3.4.0 to compare but I could try with just 3.4.0 as well if the older one is not available.

Yeah, I understand -- probably best to wait until more people report this error and hopefully someone can develop a simple test case. I literally wouldn't know where to start since the stack trace doesn't include my code, the error doesn't happen consistently, and I don't understand what the code I quoted does.

I noticed this error message after upgrading to 3.4.0., too. I could not figure out when/why, I`ll try to create a minimal example.

@mgol

@mgol we hit this in Bootstrap 4.x https://travis-ci.org/twbs/bootstrap/jobs/519620443

Going back to 3.3.1 our tests pass.

Given three independent reports, perhaps the bug should be re-opened to make it easier for others to find? (since closed bugs aren't searched by default)

Reopening it is fine, but we still don't have a test case. Can we at least get a stack trace?

The stacktrace is shown in the Travis build, but it's using the minified build. AFAICT it only affects IE 10/11, at least in our test suite.

Can we at least get a stack trace?

My second comment includes a stack trace.

AFAICT it only affects IE 10,

Chrome too.

Hi,
When is the 3.4.1 release date?

There's no set date, but it will probably be next week or the week after.

Downgraded jquery

I just broke production because of this bug.

GitHub currently pushes recommendations to all repos using jquery <3.4.0 to upgrade due to CVE-2019-5428. I saw that, so I checked out the release blog post which currently says:

There should be no compatibility issues if upgrading from jQuery 3.0+.

So after some brief sanity testing (which seemed fine) I deployed and then errors started arriving.

Given this bug, I recommend you change the wording on the blog post for 3.4.0.

Event: Fix handling of multiple async focus events

Fixed by PR #4354 (commit 24d71ac).

Any word on when a 3.4.1 release will be cut?

@vincentwoo

@vincentwoo I'm also interested when it will be out, It seems that only iOS 10 test are waiting https://github.com/jquery/jquery/milestone/20

jQuery 3.4.1 has been released! https://blog.jquery.com/2019/05/01/jquery-3-4-1-triggering-focus-events-in-ie-and-finding-root-elements-in-ios-10/

LPS-101410 Update jQuery to avoid focus/blur error jquery/jquery#4350

Event: Fix handling of multiple async focus events

Navigation Menu

Repository navigation

saved.shift is not a function #4350

16 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

saved.shift is not a function #4350

Description

Activity

dsandber commented on Apr 11, 2019

timmywil commented on Apr 11, 2019

dsandber commented on Apr 11, 2019

timmywil commented on Apr 11, 2019

dsandber commented on Apr 11, 2019

mgol commented on Apr 12, 2019

dsandber commented on Apr 12, 2019

fancyapps commented on Apr 12, 2019

XhmikosR commented on Apr 13, 2019

dsandber commented on Apr 13, 2019

dmethvin commented on Apr 13, 2019

XhmikosR commented on Apr 13, 2019

dsandber commented on Apr 13, 2019

16 remaining items

ewolfman commented on Apr 17, 2019

timmywil commented on Apr 17, 2019

dmnd commented on Apr 25, 2019

mgol commented on Apr 29, 2019

vincentwoo commented on May 1, 2019

jcubic commented on May 1, 2019

timmywil commented on May 1, 2019

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions