Repository navigation
Removed packages list is stale #34
Description
Types-publisher is still trying to remove @types/google-cloud__storage even though it's already gone.
Currently this hangs the server instead of crashing it too, because of the setInterval I used to try again. But when the interval fires, updateOneAtATime refuses to run again because the closed-over boolean doesn't get reset with the callback throws.
Activity
sandersn commentedon Feb 1, 2019
Actually, it looks like the problem is that
sandersn commentedon Feb 1, 2019
Looks like there is a workaround, at least:
I don't know why this succeeds when the normal run does not; the comments around the
--deprecatecode are not encouraging.sandersn commentedon Feb 9, 2019
Later:
--deprecatesucceeds because the way that this bug fails and microsoft/types-publisher#573 fails is that the publish of the to-be-deprecated version succeeds, but not the deprecation. There are two steps, and--deprecateonly does the deprecate, not the publish.Maybe this happens when the server crashes halfway through deprecation?
sandersn commentedon Feb 9, 2019
Also,
--deprecatedoesn't update thelatesttag.sandersn commentedon Feb 11, 2019
After further investigation, it looks like the failure of this bug and microsoft/types-publisher#573 was slightly different.
This bug
For google-cloud__storage, the deprecation process was supposed to
latesttag to 2.3.0.On the first attempt, (1) successfully happened, but (2) and (3) did not. On subsequent attempts, types-publish thought none of the steps had happened, and crashed when re-attempting (1) because npm complained that version 2.3.0 was already present.
The workaround was to run
node bin/publish-package.js --deprecate google-cloud__storage, followed bynpm deprecate @types/google-cloud__storage.publish-package.js --deprecateonly runs step (2) above.fastify-static
For fastify-static, the deprecation process was supposed to
latesttag to 2.2.0.On the first attempt, (1) sort of happened, but (2) and (3) did not. On subsequent attempts, types-publish thought none of the steps had happened, and crashed when re-attempting (1) because npm complained that version 2.2.0 was already present. However, 2.20 was not present -- but the "last updated" field indicated 2.2.0.
The workaround was to bump fastify-static in notNeededPackages.json to 2.2.1, which restarted the process.
Next steps
sandersn commentedon Jun 9, 2020
Pretty sure this is fixed by the try-again logic I added to deprecation.
Merge pull request #34 from Microsoft/no-object-literal-type-assertion
Merge pull request #34 from DefinitelyTyped/add-prepublish-script
Add dtslint/dts-critic to the monorepo (#353)