Repository navigation
Cannot remove prerelease version of package #42
Description
I've created PR here DefinitelyTyped/DefinitelyTyped#41418, which fails CI build check as the package version is prelease one (previously it was tagged as alpha, now as rc): 1.0.0-rc.2.
The check fails because of strict version check, which does not coerce prelease versions as in https://github.com/npm/node-semver/blob/70d9fb3f1c128227a3cd911867edb07a54260cad/classes/semver.js
Is that version check outcome expected (I'd close the issue) or should it be somehow addressed?
Thanks!
Somehow similar, already tracked issue:
https://github.com/microsoft/types-publisher/issues/696
Activity
sandersn commentedon Jun 9, 2020
This should be fixed, but it's not the same as #40 (nee microsoft/types-publisher#696), since there we want allow deletion of subdirectories without deprecating the whole thing. Here we want to allow deprecation with the specified target version being coerced according to semver rules.
peterblazejewicz commentedon Jun 9, 2020
Thanks, closing!
sandersn commentedon Jun 10, 2020
Oh no, I was very ambiguous! I meant "This needs to be fixed." not "This is already fixed." -- human language strikes again.
Merge pull request #42 from Microsoft/typescript-path
Merge pull request #42 from DefinitelyTyped/check-stderr-too
Add dtslint/dts-critic to the monorepo (#353)