Repository navigation
Do not spread processed notneededpackage into raw one - #219
Merged
Nathan Shively-Sanders (sandersn) merged 1 commit intoMar 23, 2021
Merged
Conversation
The compiler is fine with it, but the constructor expects strict compatibility, not subtype compatibility.
Nathan Shively-Sanders (sandersn)
requested review from
Andrew Branch (andrewbranch) and
Orta Therox (orta)
as code owners
March 23, 2021 15:43
Andrew Branch (andrewbranch)
approved these changes
Mar 23, 2021
Nathan Shively-Sanders (sandersn)
deleted the
do-not-spread-processed-into-raw
branch
March 23, 2021 15:51
Nathan Shively-Sanders (sandersn)
pushed a commit
that referenced
this pull request
Nov 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The compiler is fine with it, but the constructor expects strict compatibility, not subtype compatibility.
The real fix is not to use constructors, not to assert strict compatibility, and not to use classes at all. I'll look at this after the publisher is working again.