Repository navigation
feat: explicitly disabled more formatting rules and removed trim-file - #723
Merged
Nathan Shively-Sanders (sandersn) merged 1 commit intoAug 30, 2023
Conversation
Josh Ghoulberg 👻 (JoshuaKGoldberg)
requested review from
Andrew Branch (andrewbranch) and
Nathan Shively-Sanders (sandersn)
as code owners
August 30, 2023 22:52
Nathan Shively-Sanders (sandersn)
approved these changes
Aug 30, 2023
Josh Ghoulberg 👻 (JoshuaKGoldberg)
deleted the
explicitly-disabled-more-formatting-rules
branch
August 30, 2023 23:18
Nathan Shively-Sanders (sandersn)
added a commit
to DefinitelyTyped/DefinitelyTyped
that referenced
this pull request
Sep 8, 2023
Nathan Shively-Sanders (sandersn)
added a commit
to DefinitelyTyped/DefinitelyTyped
that referenced
this pull request
Sep 11, 2023
* Disable improved eslint rules Found by microsoft/DefinitelyTyped-tools#723 microsoft/DefinitelyTyped-tools#724 microsoft/DefinitelyTyped-tools#726 * add missed package
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These formatting rules are showing up in CI for DefinitelyTyped/DefinitelyTyped#66522. They'll no longer be useful once we finish the dprint migration.