Repository navigation
Fix submodule deletion with sign-commits - #4473
Merged
peter-evans merged 2 commits intoNov 6, 2026
Merged
Conversation
pull Bot
pushed a commit
to joshuadavidthomas/extensions
that referenced
this pull request
Sep 14, 2026
Work around an upstream bug in the create PR action by not signing commits for now. Required until peter-evans/create-pull-request#4473 or a similar fix is merged.
Owner
|
@MrSubidubi thank you for this contribution, and apologies it took me so long to get to it. I need to close and reopen the PR to recreate the checks because they have gone stale and I can't approve them anymore. |
Owner
|
/test repository=MrSubidubi/create-pull-request ref=fix-signed-submodule-deletion sign-commits=true |
Contributor
Author
|
No worries about the long delay at all! Definitely something I tend to struggle with also. Appreciate you taking a look! |
Owner
|
Released as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, thanks for provding and maintaining this action!
Whilst using this in the Zed extension repository, I got a failure whilst attempting to delete a submodule with
sign-commits: truein https://github.com/zed-industries/extensions/actions/runs/34830887346/job/103933726728The root cause for this is that the
000..SHA for a deleted submodule was provided, yet the API actually expectesnullin this case. This then caused the error as seen in the logs - the other modifications worked, yet the submodule deletion did not succeed.Fix here is to just set the submodule SHA to
nullin that case.AI disclaimer: I had Claude help me with this during debugging as well as with writing the test.