Repository navigation
Close checks list when clicking outside of modal #7157
Description
Description
Clicking anywhere outside the modal should just close it, every other modal that GH uses does close when you click outside the modal.
-
Click on the check:
-
Click anywhere outside the modal:
(modal does not close)
Example URLs
(any page that shows a commit check)
- https://github.com/refined-github/refined-github
- https://github.com/refined-github/refined-github/tree/main/source
- https://github.com/refined-github/refined-github/blob/main/source/manifest.json
Reacted by Flo Edelmann
Activity
a0m0rajab commentedon Dec 14, 2023
This could be done by adding a
clickevent listener to:div.Dialog__Backdrop-sc-uaxjsn-0.gmJJZand check if the target is that specific element then click on the X button.I could not get the dialog in the first link provided for examples though.
fregante commentedon Dec 16, 2023
That's too bad, GitHub has always dealt with modals pretty well, especially because they never had a darkened background so people don't even know it's a modal. We used to have a feature for that #735
For what it's worth, that modal can be closed via ESC
Katsute commentedon Dec 17, 2023
Implemented on https://github.com/Katsute/refined-github/blob/9715f1caecd100c2b8c456b247a94d349e87c076/source/features/checks-modal.tsx using
class^=andclass*=Should I open a PR for this feature?
a0m0rajab commentedon Dec 17, 2023
@Katsute thanks for taking this, I think you could open a PR. If @fregante does not want it, he will just close it. Otherwise, your PR will get a code review 😄 . This might save you and him some time due to the time zone differences.
Note: I am just an external programmer for the project.