Repository navigation
PHPCS: skip public hook names, Faker formatters and generated readme data - #238
Merged
Merged
Conversation
bordoni
force-pushed
the
chore/phpcs-config
branch
3 times, most recently
from
October 17, 2026 18:55
06864d9 to
b1d0cb8
Compare
… generated readme data - ValidHookName: the dotted and slashed fakerpress hook names are public API. - ConstructorName.OldStyle: false positive inside namespaces (Faker formatter methods). - Exclude node_modules/, build/ and the generated src/data/readme.php.
bordoni
force-pushed
the
chore/phpcs-config
branch
from
October 17, 2026 23:17
b1d0cb8 to
b152149
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Config only, each exclusion with its reason in
.phpcs.xml.dist:WordPress.NamingConventions.ValidHookNameoff: the hook names are public API, renaming them would break sites using them.Generic.NamingConventions.ConstructorName.OldStyleoff: Faker formatter methods share their class's short name in a namespace, which is not a PHP 4 constructor.build/,node_modules/and the generatedsrc/data/readme.php.Stacked on #237.